On Fri, 26 Oct 2018 at 11:27, Daniel Vetter <[email protected]> wrote: > > On Fri, Oct 26, 2018 at 11:05:50AM +0100, Emil Velikov wrote: > > From: Emil Velikov <[email protected]> > > > > Earlier commit updated the vgem driver to improve the topology, by > > passing a platform device as parent to drm_dev_init(). Shortly > > afterwords we updated the core function to BUG() in order to catch any > > buggy drivers passing NULL as parent. > > > > While I missed the vkms driver (as the patch predates vkms by a few > > months), the BUG caught the issue within couple of hours. > > > > Swap the drm_dev_init <> platform_device_register_simple order, to > > the driver back to life. > > > > Fixes: f08877e79485 ("drm: BUG_ON if passing NULL parent to drm_dev_init") > > Cc: Daniel Vetter <[email protected]> > > Cc: Deepak Sharma <[email protected]> > > Cc: Maarten Lankhorst <[email protected]> > > Cc: Maxime Ripard <[email protected]> > > Cc: Sean Paul <[email protected]> > > Cc: Haneen Mohammed <[email protected]> > > Cc: Rodrigo Siqueira <[email protected]> > > Reported-by: Daniel Vetter <[email protected]> > > Signed-off-by: Emil Velikov <[email protected]> > > --- > > Rodrigo, Haneen, my plan is to push the patch to the drm-misc tree. An > > Ack/Rb will be appreciated. > > Reviewed-by: Daniel Vetter <[email protected]> > Thanks, pushed via dim. Since this way breaking the 0day buildbot, I've decided to not wait too long.
> btw just read through this stuff again, and noticed how vgem is using > drm_gem_prime_import_dev(). I think now that your patches have landed we > could get rid of that? AFAICT the exynos is also using drm_gem_prime_import_dev. Having a slightly closer look, it uses a distinct component driver for DMA. One that varies across HW generation. It should be doable to rework/remove that, since my knowledge in exynos is limited, I'd refrain for now. Thanks -Emil _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
