I would suggest same aproach as for "meson_hdmi_encp_mode_1080p30" and "meson_hdmi_encp_mode_1080p60"
so duplicate "meson_hdmi_encp_mode_1080p50" with name "meson_hdmi_encp_mode_1080p25" now the code looks really like common copy paste problem Michal Lazo On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <[email protected]> wrote: > > On 21/11/2018 10:39, Christian Hewitt wrote: > > This essential mode for PAL users is missing, so add it. > > > > Signed-off-by: Christian Hewitt <[email protected]> > > --- > > drivers/gpu/drm/meson/meson_venc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/meson/meson_venc.c > > b/drivers/gpu/drm/meson/meson_venc.c > > index acbbad3..ab16046 100644 > > --- a/drivers/gpu/drm/meson/meson_venc.c > > +++ b/drivers/gpu/drm/meson/meson_venc.c > > @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode { > > { 5, &meson_hdmi_encp_mode_1080i60 }, > > { 20, &meson_hdmi_encp_mode_1080i50 }, > > { 32, &meson_hdmi_encp_mode_1080p24 }, > > + { 33, &meson_hdmi_encp_mode_1080p50 }, > > { 34, &meson_hdmi_encp_mode_1080p30 }, > > { 31, &meson_hdmi_encp_mode_1080p50 }, > > { 16, &meson_hdmi_encp_mode_1080p60 }, > > > > Exact, I forgot this mode... > > Thanks for the change ! > > Acked-by: Neil Armstrong <[email protected]> > > I'll add : > Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and > settings") > when applying to drm-misc-fixes. > > Neil > > _______________________________________________ > linux-amlogic mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Best Regards Michal Lazo Senior developer engineer mdragon.org Slovakia _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
