On Wed, 2018-12-05 at 04:35 -0500, Sasha Levin wrote:
> From: "Y.C. Chen" <[email protected]>
[]
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
[]
> @@ -973,9 +973,21 @@ static int get_clock(void *i2c_priv)
>  {
>       struct ast_i2c_chan *i2c = i2c_priv;
>       struct ast_private *ast = i2c->dev->dev_private;
> -     uint32_t val;
> +     uint32_t val, val2, count, pass;
> +
> +     count = 0;
> +     pass = 0;
> +     val = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x10) >> 4) 
> & 0x01;
> +     do {
> +             val2 = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 
> 0x10) >> 4) & 0x01;

These could have been simpler as bool using BIT

        val = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x10) & 
BIT(4);
        
etc...

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to