On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote: > Compared to the RFC[1] no changes to the patch itself, but igt moved > forward a lot: > > - gitlab CI builds with: reduced configs/libraries, arm cross build > and a sysroot build (should address all the build/cross platform > concerns raised in the RFC discussions). > > - tests reorganized into subdirectories so that the i915-gem tests > don't clog the main/shared tests directory anymore > > - quite a few more non-intel people contributing/reviewing/committing > igt tests patches. > > I think this addresses all the concerns raised in the RFC discussions, > and assuming there's enough Acks and no new issues that pop up, we can > go ahead with this. > > v2: > - Use "should" (in the usual RFC sense) to make it clear that in the > end this is all up to reviewer's discretion, as usual (Jani). > - Also in the title s/mandatory/strongly suggested/ (me) > - Make it clear we're not going to block features if a testcase is not > feasible, given hw and state of igt, both having some good gaps in > what can be tested (Harry, Eric, Sean, ...). > > 1: https://patchwork.kernel.org/patch/10648851/ > Cc: Petri Latvala <petri.latv...@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Sean Paul <s...@poorly.run> > Cc: Eric Anholt <e...@anholt.net> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Cc: Dave Airlie <airl...@redhat.com> > Cc: Daniel Stone <dan...@fooishbar.org> > Cc: "Wentland, Harry" <harry.wentl...@amd.com> > Cc: Brian Starkey <brian.star...@arm.com> > Reviewed-by: Eric Anholt <e...@anholt.net> (v1) > Acked-by: Petri Latvala <petri.latv...@intel.com> > Acked-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Acked-by: Sean Paul <s...@poorly.run> > Acked-by: "Wentland, Harry" <harry.wentl...@amd.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
With all the additional ones I think we have enough acks, and Dave agreed that this seems ready to go. Merged into drm-misc-next. Thanks everyone for helping figuring this out, and if anything pops up, pls raise it so we can clarify the documentation. Cheers, Daniel > --- > Documentation/gpu/drm-uapi.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst > index a752aa561ea4..c9fd23efd957 100644 > --- a/Documentation/gpu/drm-uapi.rst > +++ b/Documentation/gpu/drm-uapi.rst > @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly > unintuitive meaning of > Testing and validation > ====================== > > +Testing Requirements for userspace API > +-------------------------------------- > + > +New cross-driver userspace interface extensions, like new IOCTL, new KMS > +properties, new files in sysfs or anything else that constitutes an API > change > +should have driver-agnostic testcases in IGT for that feature, if such a test > +can be reasonably made using IGT for the target hardware. > + > Validating changes with IGT > --------------------------- > > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
