Hi, ping & actually add the cc :)
-- Sebastian On Tue, Dec 11, 2018 at 10:06:07AM +0200, Laurent Pinchart wrote: >> The problem is, that DISPC timings for DSI are not directly >> calculated from mode. Instead DSI code does some modifications >> before applying the DISPC settings. > > I wonder what the best way to fix this would be. DSI isn't so special in this > regard, any encoder can modify modes, resulting in the CRTC outputting a mode > significantly different than the mode being displayed. This is handled by the > DRM helpers through the .mode_fixup() operations, which can mangle modes > along > the pipeline. > > At atomic commit time the atomic helpers call .mode_valid() first, followed > by > .mode_fixup(). An easy fix would be to remove our .mode_valid() handlers > completely and perform both fixup and validation in the .mode_fixup() > handlers. > > However, the .mode_valid() operations are also used in > drm_helper_probe_single_connector_modes(), where no mode fixup is performed. > We can't drop .mode_valid() for that code path (at least not as anything else > than a hack). Daniel, what's the expected way to handle this ? > > -- > Regards, > > Laurent Pinchart
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
