On Mon, Feb 18, 2019 at 1:07 PM Vasily Khoruzhick <anars...@gmail.com> wrote: > > On Mon, Feb 18, 2019 at 10:33 AM Rob Herring <r...@kernel.org> wrote: > > > > On Thu, Feb 14, 2019 at 09:09:56PM -0800, Vasily Khoruzhick wrote: > > > This commit adds support for the NewEast Optoelectronics CO., LTD > > > WJFH116008A 11.6" 1920x1080 TFT LCD panel. > > > > > > Signed-off-by: Vasily Khoruzhick <anars...@gmail.com> > > > --- > > > .../display/panel/neweast,wjfh116008a.txt | 7 ++++ > > > drivers/gpu/drm/panel/panel-simple.c | 39 +++++++++++++++++++ > > > 2 files changed, 46 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/display/panel/neweast,wjfh116008a.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/panel/neweast,wjfh116008a.txt > > > b/Documentation/devicetree/bindings/display/panel/neweast,wjfh116008a.txt > > > new file mode 100644 > > > index 000000000000..d76579f9f55e > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/display/panel/neweast,wjfh116008a.txt > > > @@ -0,0 +1,7 @@ > > > +NewEast Optoelectronics CO., LTD WJFH116008A 11.6" 1920x1080 TFT LCD > > > panel > > > + > > > +Required properties: > > > +- compatible: should be "neweast,wjfh116008a" > > > + > > > +This binding is compatible with the simple-panel binding, which is > > > specified > > > +in simple-panel.txt in this directory. > > > > We already established that this goes thru a standard eDP connector. We > > should describe that and everything associated with it. > > I believe using eDP connector binding wouldn't help much in my case > and it won't improve accuracy of hardware description while adding > unnecessary code duplication (edp-connector will be pretty much > simple-panel). > > Since currently there're no standalone connector drivers, implementing > one requires significant refactoring of the code that I'm not > familiar.
I'm not talking about drivers. I'm talking about bindings. Those are not necessarily 1-1. There's no reason the simple panel driver can't have an 'edp-connector' entry. Also, since you have EDID, you should be using that for timing data IMO, and the binding needs to have enough information to support that. It may if DP-aux comes from the bridge chip or it may not if you need to describe that connection. Again, this is independent from what Linux chooses to do. If Linux chooses to have its own timing information that's its choice. Another OS may choose to use EDID. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
