Hi Qiang. Two general comments: - We are trying to avoid drmP.h in new drivers, please drop - The use of idr is being replaced with XArray, see patch-set posted by Matthew Wilcox. Try to use XArray so we do not introduce a new user.
This was from a very quick looks at the driver. In general things looked good, but these two issues I stumbled upon. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel