Hi Jyri,
I also implemented HDMI audio support for sii902x to enable audio on a
STM32 board. As you submitted your patches first, I will align on it.
I had a first look at the current patch and I have some comments below.
I will review more in details and make some tests, asap.
I agree with Laurent and Andrzej regarding the missing audio connection
in DT. I would expect a subnode in DT describing the connection between
the HDMI codec and the CPU DAI.
Typically:
port@1 {
reg = <1>;
codec_endpoint: endpoint {
remote-endpoint = <&cpu_dai_endpoint>;
};
};
Then the hdmi codec get_dai_id callback can be implemented to check the
endpoint used for audio.
mclk and i2s-fifo-routing properties are defined as optional properties
in bindings.
However, these properties are required to initialize to the audio codec
in the code.
- master clock:
The i2s link of sii902x can be used without master clock. So the master
clock property has to be made actually optional. Probably, error code
-ENOENT should be checked on devm_clk_get() call, to ignore mclk if the
property is not defined.
- i2s-fifo-routing:
fifo mapping maybe set by default, according to i2s_fifo_defaults array
if the property is not set.
Best regards
Olivier
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
