Hi Laurent,
On 12/03/2019 15:24, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Mon, Mar 11, 2019 at 10:57:15PM +0000, Kieran Bingham wrote:
>> On 21/02/2019 10:32, Laurent Pinchart wrote:
>>> The rcar_du_crtc structure index field contains the CRTC hardware index,
>>> not the hardware and software index. Update the documentation
>>> accordingly.
>>
>> Should this have a fixes tag? It's only trivial - but if so:
>>
>> Fixes: 5361cc7f8e91 ("drm: rcar-du: Split CRTC handling to support
>> hardware indexing")
>
> I'll add it for correctness, I just hope it won't be automatically
> backported to stable.
I would expect that it should only be backported if the patch it fixes
(5361cc7f8e91) has also been backported?
>
>> Either way,
>>
>> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
>>> ---
>>> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
>>> b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
>>> index bcb35b0b7612..c478953be092 100644
>>> --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
>>> +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
>>> @@ -27,7 +27,7 @@ struct rcar_du_vsp;
>>> * @clock: the CRTC functional clock
>>> * @extclock: external pixel dot clock (optional)
>>> * @mmio_offset: offset of the CRTC registers in the DU MMIO block
>>> - * @index: CRTC software and hardware index
>>> + * @index: CRTC hardware index
>>> * @initialized: whether the CRTC has been initialized and clocks enabled
>>> * @dsysr: cached value of the DSYSR register
>>> * @vblank_enable: whether vblank events are enabled on this CRTC
>
--
Regards
--
Kieran
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
