> -----Original Message----- > From: Shankar, Uma > Sent: Monday, March 11, 2019 9:28 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Lankhorst, Maarten <maarten.lankho...@intel.com>; Syrjala, Ville > <ville.syrj...@intel.com>; Sharma, Shashank <shashank.sha...@intel.com>; > emil.l.veli...@gmail.com; brian.star...@arm.com; liviu.du...@arm.com; Shankar, > Uma <uma.shan...@intel.com> > Subject: [v5 04/13] drm/i915: Attach HDR metadata property to connector > > Attach HDR metadata property to connector object. > > v2: Rebase > > v3: Updated the property name as per updated name while creating hdr metadata > property > > Signed-off-by: Uma Shankar <uma.shan...@intel.com> > --- > drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c > b/drivers/gpu/drm/i915/intel_hdmi.c > index cd422a7..0952475 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -2719,6 +2719,8 @@ static void intel_hdmi_destroy(struct drm_connector > *connector) > > drm_connector_attach_content_type_property(connector); > connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE; > + drm_object_attach_property(&connector->base, > + connector->dev->mode_config.hdr_output_metadata_property, 0); 'connector->dev' should be aligned to the line above, but seems like you have done this to meet the 80 char limit. May be a local ptr variable will help with 80 char.
Apart from that, looks good to me, and feel free to use: Reviewed-by: Shashank Sharma <shashank.sha...@intel.com> > > if (!HAS_GMCH(dev_priv)) > drm_connector_attach_max_bpc_property(connector, 8, 12); > -- > 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
