On Tue, Mar 19, 2019 at 7:26 AM Brian Starkey <brian.star...@arm.com> wrote: > > Hi John, > > On Tue, Mar 05, 2019 at 12:54:30PM -0800, John Stultz wrote: > > ... > > > + > > +void dma_heap_buffer_destroy(struct dma_heap_buffer *heap_buffer) > > +{ > > + struct heap_helper_buffer *buffer = to_helper_buffer(heap_buffer); > > + > > + if (buffer->kmap_cnt > 0) { > > + pr_warn_once("%s: buffer still mapped in the kernel\n", > > + __func__); > > Could be worth something louder like a full WARN. > > > + vunmap(buffer->vaddr); > > + } > > + > > + buffer->free(buffer); > > +} > > + > > ... > > > + > > +static void *dma_heap_dma_buf_kmap(struct dma_buf *dmabuf, > > + unsigned long offset) > > +{ > > + struct dma_heap_buffer *heap_buffer = dmabuf->priv; > > + struct heap_helper_buffer *buffer = to_helper_buffer(heap_buffer); > > + > > + return buffer->vaddr + offset * PAGE_SIZE; > > I think it'd be good to check for NULL vaddr and return NULL in that > case. Less chance of an invalid pointer being accidentally used then.
Thanks so much for the feedback! I've added these two suggestions in! -john _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel