* Hans Verkuil <hverk...@xs4all.nl> [190326 06:36]:
> On 3/26/19 12:47 AM, Tony Lindgren wrote:
> > @@ -169,12 +169,19 @@ static int hdmi_cec_adap_enable(struct cec_adapter 
> > *adap, bool enable)
> >     struct hdmi_core_data *core = cec_get_drvdata(adap);
> >     int temp, err;
> >  
> > -   if (!enable) {
> > +   if (enable) {
> > +           /*
> > +            * Initialize CEC clock divider: CEC needs 2MHz clock hence
> > +            * set the divider to 24 to get 48/24=2MHz clock
> > +            */
> > +           REG_FLD_MOD(core->wp->base, HDMI_WP_CLK, 0x18, 5, 0);
> 
> Please move this to after the 'if'. That's where all the other
> 'enable' code is.

Oops yeah that's better, will post v2 shortly.

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to