Hello, On 2/1/19 22:05, Stefan Agner wrote: > On 02.01.2019 18:02, Ahmad Fatoum wrote: >> Hello, >> >> I got a board with the RED[0:7]/BLUE[0:7] lanes originating from the >> LCDIF swapped and would like to describe this in the device tree: >> >> This first patch extends the mxsfb driver to support >> following bus formats: >> MEDIA_BUS_FMT_BGR888_1X24 >> MEDIA_BUS_FMT_RBG888_1X24 >> MEDIA_BUS_FMT_GBR888_1X24 >> >> The latter two patches add a new interface-pix-fmt property >> (named so because fsl,imx-parallel-display has one), >> which allows a device tree to override the bus format to account >> for swapped signal lanes. >> >> Thoughts? > > On a quick glance patch 1 looks good.
Did you have time to look at this again? Only the first patch is relevant, please ignore the other two. > > However, patch 2/3 are probably unnecessary when using of graph/panel > support. E.g. panel-simple.c supports bus formats. I decided against trying to make this configurable over device tree. I'll make use of this by specifying the adjusted bus format in a new panel-simple.c entry. > > Is the display you are using regular RGB and only the board/connectors > happen to swap colors? > > -- > Stefan > >> >> Cheers >> Ahmad >> >> -- >> >> Ahmad Fatoum (3): >> drm/mxsfb: use bus_format to determine pixel RGB component order >> drm/mxsfb: implement interface-pix-fmt of_property to override bus >> format >> dt-bindings: mxsfb: document new interface-pix-fmt property >> >> .../devicetree/bindings/display/mxsfb.txt | 5 +++ >> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 45 +++++++++++++++---- >> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 13 ++++++ >> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 7 +++ >> drivers/gpu/drm/mxsfb/mxsfb_regs.h | 17 +++++++ >> 5 files changed, 79 insertions(+), 8 deletions(-) > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
