On 08/04/2019 14:20, Qiang Yu wrote:
> On Mon, Apr 8, 2019 at 7:56 PM Neil Armstrong <narmstr...@baylibre.com> wrote:
>>
>> Hi,
>>
>> On 08/04/2019 13:26, Qiang Yu wrote:
>>> Feedback from kbuild robot:
>>> config: sh-allyesconfig (attached as .config)
>>> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>>> lima_gem.c:(.text+0x6c): undefined reference to `vmf_insert_mixed'
>>>
>>> Cc: Randy Dunlap <rdun...@infradead.org>
>>> Signed-off-by: Qiang Yu <yuq...@gmail.com>
>>
>> You'll need a Fixes tag here, even if on the same release
>>
> So like this?
> Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")Yes > >>> --- >>> drivers/gpu/drm/lima/Kconfig | 2 ++ >>> drivers/gpu/drm/lima/lima_gem.c | 1 + >>> 2 files changed, 3 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/lima/Kconfig b/drivers/gpu/drm/lima/Kconfig >>> index f11314448093..fed2b0863287 100644 >>> --- a/drivers/gpu/drm/lima/Kconfig >>> +++ b/drivers/gpu/drm/lima/Kconfig >>> @@ -5,6 +5,8 @@ config DRM_LIMA >>> tristate "LIMA (DRM support for ARM Mali 400/450 GPU)" >>> depends on DRM >>> depends on ARM || ARM64 || COMPILE_TEST >>> + depends on MMU >>> + depends on COMMON_CLK >>> select DRM_SCHED >>> help >>> DRM driver for ARM Mali 400/450 GPUs. >>> diff --git a/drivers/gpu/drm/lima/lima_gem.c >>> b/drivers/gpu/drm/lima/lima_gem.c >>> index 2d3cf96f6c58..1d69498bc17e 100644 >>> --- a/drivers/gpu/drm/lima/lima_gem.c >>> +++ b/drivers/gpu/drm/lima/lima_gem.c >>> @@ -1,6 +1,7 @@ >>> // SPDX-License-Identifier: GPL-2.0 OR MIT >>> /* Copyright 2017-2019 Qiang Yu <yuq...@gmail.com> */ >>> >>> +#include <linux/mm.h> >> >> I would have fixed this on a second patch > > This is suggested by Randy, I expect it's also part of the fix for build fail > when MMU-less platform, MMU platform is OK. Should I still separate it? Yes but one fixes the Kconfig and another fixes the code, TBH it's fine for me, maybe daniel or someone else can give a feedback about this. > > Thanks, > Qiang > >> >>> #include <linux/sync_file.h> >>> #include <linux/pfn_t.h> >>> >>> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
