On 10/04/2019 14:43, Noralf Trønnes wrote: > Due to copy/paste error, the fbdev format was changed to 32bpp = XRGB8888 > which is an emulated format for the RGB565 drivers. Revert to to using the > fallback which is dev->mode_config.preferred_depth for the drivers that > set it or 32bpp for those that don't (repaper, st7586). > > Fixes: 3eba3922819f ("drm/tinydrm: Drop using tinydrm_device") > Signed-off-by: Noralf Trønnes <nor...@tronnes.org> > --- > drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- > drivers/gpu/drm/tinydrm/ili9225.c | 2 +- > drivers/gpu/drm/tinydrm/ili9341.c | 2 +- > drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- > drivers/gpu/drm/tinydrm/repaper.c | 2 +- > drivers/gpu/drm/tinydrm/st7586.c | 2 +- > drivers/gpu/drm/tinydrm/st7735r.c | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/tinydrm/hx8357d.c > b/drivers/gpu/drm/tinydrm/hx8357d.c > index fab961dded87..5773d0fb6ca1 100644 > --- a/drivers/gpu/drm/tinydrm/hx8357d.c > +++ b/drivers/gpu/drm/tinydrm/hx8357d.c > @@ -267,7 +267,7 @@ static int hx8357d_probe(struct spi_device *spi) > > spi_set_drvdata(spi, drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/ili9225.c > b/drivers/gpu/drm/tinydrm/ili9225.c > index e9116ef4b5bc..4b1a587c0134 100644 > --- a/drivers/gpu/drm/tinydrm/ili9225.c > +++ b/drivers/gpu/drm/tinydrm/ili9225.c > @@ -433,7 +433,7 @@ static int ili9225_probe(struct spi_device *spi) > > spi_set_drvdata(spi, drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/ili9341.c > b/drivers/gpu/drm/tinydrm/ili9341.c > index d15f85e837ae..4ade9e4b924f 100644 > --- a/drivers/gpu/drm/tinydrm/ili9341.c > +++ b/drivers/gpu/drm/tinydrm/ili9341.c > @@ -229,7 +229,7 @@ static int ili9341_probe(struct spi_device *spi) > > spi_set_drvdata(spi, drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c > b/drivers/gpu/drm/tinydrm/mi0283qt.c > index c6dc31084a4e..8e169846fbd8 100644 > --- a/drivers/gpu/drm/tinydrm/mi0283qt.c > +++ b/drivers/gpu/drm/tinydrm/mi0283qt.c > @@ -242,7 +242,7 @@ static int mi0283qt_probe(struct spi_device *spi) > > spi_set_drvdata(spi, drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/repaper.c > b/drivers/gpu/drm/tinydrm/repaper.c > index a29b8278324b..370629e2de94 100644 > --- a/drivers/gpu/drm/tinydrm/repaper.c > +++ b/drivers/gpu/drm/tinydrm/repaper.c > @@ -1131,7 +1131,7 @@ static int repaper_probe(struct spi_device *spi) > > DRM_DEBUG_DRIVER("SPI speed: %uMHz\n", spi->max_speed_hz / 1000000); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/st7586.c > b/drivers/gpu/drm/tinydrm/st7586.c > index 560d7ac0cadc..36bb16a15f7e 100644 > --- a/drivers/gpu/drm/tinydrm/st7586.c > +++ b/drivers/gpu/drm/tinydrm/st7586.c > @@ -408,7 +408,7 @@ static int st7586_probe(struct spi_device *spi) > DRM_DEBUG_KMS("preferred_depth=%u, rotation = %u\n", > drm->mode_config.preferred_depth, rotation); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/st7735r.c > b/drivers/gpu/drm/tinydrm/st7735r.c > index 022e9849b95b..ce9109e613e0 100644 > --- a/drivers/gpu/drm/tinydrm/st7735r.c > +++ b/drivers/gpu/drm/tinydrm/st7735r.c > @@ -207,7 +207,7 @@ static int st7735r_probe(struct spi_device *spi) > > spi_set_drvdata(spi, drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } >
Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel