Hi Daniel, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-notifier-begone/20190521-021841 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/video/fbdev/core/fbcon.c: In function 'fbcon_set_con2fb_map_ioctl': >> drivers/video/fbdev/core/fbcon.c:3323:6: error: implicit declaration of >> function 'copy_from_user'; did you mean 'sg_copy_from_buffer'? >> [-Werror=implicit-function-declaration] if (copy_from_user(&con2fb, argp, sizeof(con2fb))) ^~~~~~~~~~~~~~ sg_copy_from_buffer drivers/video/fbdev/core/fbcon.c: In function 'fbcon_get_con2fb_map_ioctl': drivers/video/fbdev/core/fbcon.c:3356:9: error: implicit declaration of function 'copy_to_user'; did you mean 'cpu_to_mem'? [-Werror=implicit-function-declaration] return copy_to_user(argp, &con2fb, sizeof(con2fb)) ? -EFAULT : 0; ^~~~~~~~~~~~ cpu_to_mem cc1: some warnings being treated as errors vim +3323 drivers/video/fbdev/core/fbcon.c 3317 3318 int fbcon_set_con2fb_map_ioctl(void __user *argp) 3319 { 3320 struct fb_con2fbmap con2fb; 3321 int ret; 3322 > 3323 if (copy_from_user(&con2fb, argp, sizeof(con2fb))) 3324 return -EFAULT; 3325 if (con2fb.console < 1 || con2fb.console > MAX_NR_CONSOLES) 3326 return -EINVAL; 3327 if (con2fb.framebuffer >= FB_MAX) 3328 return -EINVAL; 3329 if (!registered_fb[con2fb.framebuffer]) 3330 request_module("fb%d", con2fb.framebuffer); 3331 if (!registered_fb[con2fb.framebuffer]) { 3332 return -EINVAL; 3333 } 3334 3335 console_lock(); 3336 ret = set_con2fb_map(con2fb.console - 1, 3337 con2fb.framebuffer, 1); 3338 console_unlock(); 3339 3340 return ret; 3341 } 3342 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
