Hi Yannick, and thank you for your patch. Tested successfully on stm32f too.
Reviewed-by: Philippe Cornu <[email protected]> Tested-by: Philippe Cornu <[email protected]> Philippe :-) On 5/27/19 12:21 PM, Yannick Fertré wrote: > Add power on & off optional physical operation functions, helpful to > program specific registers of the DSI physical part. > > Signed-off-by: Yannick Fertré <[email protected]> > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 ++++++++ > include/drm/bridge/dw_mipi_dsi.h | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index e915ae8..5bb676f 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -775,6 +775,10 @@ static void dw_mipi_dsi_clear_err(struct dw_mipi_dsi > *dsi) > static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge) > { > struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge); > + const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops; > + > + if (phy_ops->power_off) > + phy_ops->power_off(dsi->plat_data->priv_data); > > /* > * Switch to command mode before panel-bridge post_disable & > @@ -874,11 +878,15 @@ static void dw_mipi_dsi_bridge_mode_set(struct > drm_bridge *bridge, > static void dw_mipi_dsi_bridge_enable(struct drm_bridge *bridge) > { > struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge); > + const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops; > > /* Switch to video mode for panel-bridge enable & panel enable */ > dw_mipi_dsi_set_mode(dsi, MIPI_DSI_MODE_VIDEO); > if (dsi->slave) > dw_mipi_dsi_set_mode(dsi->slave, MIPI_DSI_MODE_VIDEO); > + > + if (phy_ops->power_on) > + phy_ops->power_on(dsi->plat_data->priv_data); > } > > static enum drm_mode_status > diff --git a/include/drm/bridge/dw_mipi_dsi.h > b/include/drm/bridge/dw_mipi_dsi.h > index 7d3dd69..df6eda6 100644 > --- a/include/drm/bridge/dw_mipi_dsi.h > +++ b/include/drm/bridge/dw_mipi_dsi.h > @@ -14,6 +14,8 @@ struct dw_mipi_dsi; > > struct dw_mipi_dsi_phy_ops { > int (*init)(void *priv_data); > + void (*power_on)(void *priv_data); > + void (*power_off)(void *priv_data); > int (*get_lane_mbps)(void *priv_data, > const struct drm_display_mode *mode, > unsigned long mode_flags, u32 lanes, u32 format, > _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
