On 03.06.2019 16:21, Colin King wrote: > From: Colin Ian King <[email protected]> > > The less than check for the variable num_lanes is always going to be > false because the variable is a u32. Fix this by making num_lanes an > int and also make loop index i an int too. > > Addresses-Coverity: ("Unsigned compared against 0")
Is there a rule in Kernel of adding such tags? I have spotted only: Addresses-Coverity-ID? Beside this: Reviewed-by: Andrzej Hajda <[email protected]> -- Regards Andrzej > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c > b/drivers/gpu/drm/bridge/sii902x.c > index d6f98d388ac2..21a947603c88 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -719,7 +719,7 @@ static int sii902x_audio_codec_init(struct sii902x > *sii902x, > .max_i2s_channels = 0, > }; > u8 lanes[4]; > - u32 num_lanes, i; > + int num_lanes, i; > > if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
