On Tuesday, 2019-06-18 16:02:41 +0200, Daniel Vetter wrote: > I rushed merging this a bit too much, and Noralf pointed out that > we're a lot better already and have made great progress. > > Let's try again. > > Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo") > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Daniel Vetter <daniel.vet...@intel.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Maxime Ripard <maxime.rip...@bootlin.com> > Cc: Sean Paul <s...@poorly.run> > Cc: Thomas Zimmermann <tzimmerm...@suse.de> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Rob Herring <r...@kernel.org> > Cc: Noralf Trønnes <nor...@tronnes.org> > Cc: Eric Anholt <e...@anholt.net> > Cc: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > --- > Documentation/gpu/todo.rst | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 25878dd048fd..66c123737c3d 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -212,9 +212,11 @@ struct drm_gem_object_funcs > GEM objects can now have a function table instead of having the callbacks on > the > DRM driver struct. This is now the preferred way and drivers can be moved > over. > > -Unfortunately some of the recently added GEM helpers are going in the wrong > -direction by adding OPS macros that use the old, deprecated hooks. See > -DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS, and > DRM_GEM_VRAM_DRIVER_PRIME. > +DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS already support this, > but > +DRM_GEM_VRAM_DRIVER_PRIME does not yet and needs to be aligend with the > previous
s/aligend/aligned/ > +two. We also need a 2nd version of the CMA define that doesn't require the > +vmapping to be present (different hook for prime importing). Plus this needs > to > +be rolled out to all drivers using their own implementations, too. > > Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate > --------------------------------------------------------- > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel