Op 24-06-2019 om 10:32 schreef Daniel Vetter: > Fixes linking fail when fbcon/fbdev is moduler and vgaswitcheroo is > enabled: > > x86_64-linux-gnu-ld: drivers/gpu/vga/vga_switcheroo.o: in function > `vga_switchto_stage2': > vga_switcheroo.c:(.text+0x997): undefined reference to `fbcon_remap_all' > > Reported-by: Stephen Rothwell <[email protected]> > Reported-by: kbuild test robot <[email protected]> > Fixes: 1cd51b5d200d ("vgaswitcheroo: call fbcon_remap_all directly") > Cc: Stephen Rothwell <[email protected]> > Cc: Lukas Wunner <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Sam Ravnborg <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: Bartlomiej Zolnierkiewicz <[email protected]> > Cc: Hans de Goede <[email protected]> > Cc: Yisheng Xie <[email protected]> > Cc: [email protected] > Cc: Daniel Thompson <[email protected]> > Cc: Lee Jones <[email protected]> > Cc: [email protected] > Cc: [email protected] > -- > wrt merging probably best if Maarten adds this to the topic branch we > have already and sends out an updated pull request. > > Apologies for the mess. > -Daniel > --- > drivers/video/fbdev/core/fbcon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/core/fbcon.c > b/drivers/video/fbdev/core/fbcon.c > index c9235a2f42f8..199ca723c768 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3194,6 +3194,7 @@ void fbcon_remap_all(struct fb_info *info) > } > console_unlock(); > } > +EXPORT_SYMBOL(fbcon_remap_all); > > #ifdef CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY > static void fbcon_select_primary(struct fb_info *info)
Did you test this on a allmodconfig? fbcon_remap_all is in a module, vga switcheroo is builtin, even with this patch you will still get the same compile failure. ~Maarten _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
