Hi Doug.
On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote:
> This attempts to address outstanding review feedback from commit
> b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical
> timing"). Specifically:
>
> * It was requested that I document (in the structure definition) that
> the device tree override had no effect if 'struct drm_display_mode'
> was used in the panel description. I have provided full Doxygen
> comments for 'struct panel_desc' to accomplish that.
> * panel_simple_get_fixed_modes() was thought to be a confusing name,
> so it has been renamed to panel_simple_get_display_modes().
> * panel_simple_parse_override_mode() was thought to be better named as
> panel_simple_parse_panel_timing_node().
>
> Suggested-by: Sam Ravnborg <s...@ravnborg.org>
> Signed-off-by: Douglas Anderson <diand...@chromium.org>
Thanks.
I updated the $subject to:
drm/panel: simple: document panel_desc; rename a few functions
And pushed out to drm-misc-next.
> - Sam said that there was still something that he didn't understand
> with regards to the flags. Sam: if this is something that needs to
> be addressed, please yell.
Need to re-visit this later when I have familiarized myself with
the new yaml syntax and what impact any potential changes may have on
the panel drivers.
So for now we leave it as is.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
