Hi Sean,
Am Donnerstag, 25. Juli 2019, 20:08:12 CEST schrieb Sean Paul:
> On Tue, Jun 11, 2019 at 12:08:21PM -0400, Sean Paul wrote:
> > From: Sean Paul <[email protected]>
> >
> > Once we start shutting off the link during PSR, we're going to want fast
> > training to work. If the display doesn't support fast training, don't
> > enable psr.
> >
> > Changes in v2:
> > - None
> > Changes in v3:
> > - None
> > Changes in v4:
> > - None
> > Changes in v5:
> > - None
> >
> > Link to v1:
> > https://patchwork.freedesktop.org/patch/msgid/[email protected]
> > Link to v2:
> > https://patchwork.freedesktop.org/patch/msgid/[email protected]
> > Link to v3:
> > https://patchwork.freedesktop.org/patch/msgid/[email protected]
> > Link to v4:
> > https://patchwork.freedesktop.org/patch/msgid/[email protected]
> >
> > Cc: Zain Wang <[email protected]>
> > Cc: Tomasz Figa <[email protected]>
> > Tested-by: Heiko Stuebner <[email protected]>
>
> @Heiko, could you please review patches 7-11? I'm worried they're going to
> start
> to rot and the helpers have already landed in Linus' tree.
I did look through the patches and nothing out of the ordinary sprang
out to my (somewhat untrained) eye and judging by my tested-tags I also
gave them a spin at some point - although it seems I never was actually on
cc for them.
In any case they look good to me, so if it helps you, you can add my
Reviewed-by: Heiko Stuebner <[email protected]>
though should take the technical expertise on drm-internals with a
grain of salt.
Heiko
> > Signed-off-by: Sean Paul <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > index d2de98d441845..a07d19e08b803 100644
> > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > @@ -1040,16 +1040,17 @@ static int analogix_dp_commit(struct
> > analogix_dp_device *dp)
> > if (ret)
> > return ret;
> >
> > + /* Check whether panel supports fast training */
> > + ret = analogix_dp_fast_link_train_detection(dp);
> > + if (ret)
> > + dp->psr_enable = false;
> > +
> > if (dp->psr_enable) {
> > ret = analogix_dp_enable_sink_psr(dp);
> > if (ret)
> > return ret;
> > }
> >
> > - /* Check whether panel supports fast training */
> > - ret = analogix_dp_fast_link_train_detection(dp);
> > - if (ret)
> > - dp->psr_enable = false;
> >
> > return ret;
> > }
>
>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
