On Wed, Aug 21, 2019 at 10:38:35PM +0200, Daniel Vetter wrote:
> Oops.
>
> Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs")
> Cc: Tomeu Vizoso <[email protected]>
> Cc: Emil Velikov <[email protected]>
> Cc: Benjamin Gaignard <[email protected]>
> Signed-off-by: Daniel Vetter <[email protected]>
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c
> b/drivers/gpu/drm/drm_debugfs_crc.c
> index be1b7ba92ffe..6fe693ee15f9 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -369,7 +369,7 @@ void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc)
>
> crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry);
>
> - debugfs_create_file("control", S_IRUGO, crc_ent, crtc,
> + debugfs_create_file("control", S_IRUGO | S_IWUSR, crc_ent, crtc,
> &drm_crtc_crc_control_fops);
Reviewed-by: Ville Syrjälä <[email protected]>
But could we please go octal? My brain can't decode that alphabet soup.
> debugfs_create_file("data", S_IRUGO, crc_ent, crtc,
> &drm_crtc_crc_data_fops);
> --
> 2.23.0.rc1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
