Hi Jacopo,

Thank you for the patch.

On Sun, Aug 25, 2019 at 03:51:47PM +0200, Jacopo Mondi wrote:
> Add CMM units to Renesas R-Car D3 device tree and reference them from
> the Display Unit they are connected to.
> 
> While at it, re-sort the du device node properties to match the ordering
> found in other SoCs.
> 
> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>

Apart from the issue with compatible string as pointed out for patch
03/14,

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 183fef86cf7c..b91a20fbbbc6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -993,6 +993,22 @@
>                       iommus = <&ipmmu_vi0 9>;
>               };
>  
> +             cmm0: cmm@fea40000 {
> +                     compatible = "renesas,cmm-r8a77995";
> +                     reg = <0 0xfea40000 0 0x1000>;
> +                     clocks = <&cpg CPG_MOD 711>;
> +                     power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> +                     resets = <&cpg 711>;
> +             };
> +
> +             cmm1: cmm@fea50000 {
> +                     compatible = "renesas,cmm-r8a77995";
> +                     reg = <0 0xfea50000 0 0x1000>;
> +                     clocks = <&cpg CPG_MOD 710>;
> +                     power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> +                     resets = <&cpg 710>;
> +             };
> +
>               du: display@feb00000 {
>                       compatible = "renesas,du-r8a77995";
>                       reg = <0 0xfeb00000 0 0x40000>;
> @@ -1003,9 +1019,11 @@
>                       clock-names = "du.0", "du.1";
>                       resets = <&cpg 724>;
>                       reset-names = "du.0";
> -                     vsps = <&vspd0 0>, <&vspd1 0>;
>                       status = "disabled";
>  
> +                     vsps = <&vspd0 0>, <&vspd1 0>;
> +                     cmms = <&cmm0 &cmm1>;
> +
>                       ports {
>                               #address-cells = <1>;
>                               #size-cells = <0>;

-- 
Regards,

Laurent Pinchart

Reply via email to