On Fri, Oct 4, 2019 at 8:25 AM zhengbin <zhengbi...@huawei.com> wrote: > > Fix sparse warnings: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:32:6: > warning: symbol 'lp_write_i2c' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:42:6: > warning: symbol 'lp_read_i2c' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:52:6: > warning: symbol 'lp_write_dpcd' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:59:6: > warning: symbol 'lp_read_dpcd' was not declared. Should it be static? > > Reported-by: Hulk Robot <hul...@huawei.com> > Signed-off-by: zhengbin <zhengbi...@huawei.com>
Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c > index 2443c23..77181dd 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c > @@ -29,7 +29,8 @@ > #include "dm_helpers.h" > #include <drm/drm_hdcp.h> > > -bool lp_write_i2c(void *handle, uint32_t address, const uint8_t *data, > uint32_t size) > +static bool > +lp_write_i2c(void *handle, uint32_t address, const uint8_t *data, uint32_t > size) > { > > struct dc_link *link = handle; > @@ -39,7 +40,8 @@ bool lp_write_i2c(void *handle, uint32_t address, const > uint8_t *data, uint32_t > return dm_helpers_submit_i2c(link->ctx, link, &cmd); > } > > -bool lp_read_i2c(void *handle, uint32_t address, uint8_t offset, uint8_t > *data, uint32_t size) > +static bool > +lp_read_i2c(void *handle, uint32_t address, uint8_t offset, uint8_t *data, > uint32_t size) > { > struct dc_link *link = handle; > > @@ -49,14 +51,16 @@ bool lp_read_i2c(void *handle, uint32_t address, uint8_t > offset, uint8_t *data, > return dm_helpers_submit_i2c(link->ctx, link, &cmd); > } > > -bool lp_write_dpcd(void *handle, uint32_t address, const uint8_t *data, > uint32_t size) > +static bool > +lp_write_dpcd(void *handle, uint32_t address, const uint8_t *data, uint32_t > size) > { > struct dc_link *link = handle; > > return dm_helpers_dp_write_dpcd(link->ctx, link, address, data, size); > } > > -bool lp_read_dpcd(void *handle, uint32_t address, uint8_t *data, uint32_t > size) > +static bool > +lp_read_dpcd(void *handle, uint32_t address, uint8_t *data, uint32_t size) > { > struct dc_link *link = handle; > > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel