On Wed, Oct 09, 2019 at 12:46:07PM +0100, Ben Dooks wrote:
> The a5xx_show and a5xx_gpu_state_put objects are not exported
> outside of the file, so make them static to avoid the following
> warnings from sparse:
>
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol
> 'a5xx_gpu_state_put' was not declared. Should it be static?
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was
> not declared. Should it be static?
Reviewed-by: Jordan Crouse <jcro...@codeaurora.org>
> Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>
> ---
> Cc: Rob Clark <robdcl...@gmail.com>
> Cc: Sean Paul <s...@poorly.run>
> Cc: David Airlie <airl...@linux.ie>
> Cc: Daniel Vetter <dan...@ffwll.ch>
> Cc: linux-arm-...@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedr...@lists.freedesktop.org
> ---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> index e9c55d1d6c04..7fdc9e2bcaac 100644
> --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> @@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)
> kfree(a5xx_state);
> }
>
> -int a5xx_gpu_state_put(struct msm_gpu_state *state)
> +static int a5xx_gpu_state_put(struct msm_gpu_state *state)
> {
> if (IS_ERR_OR_NULL(state))
> return 1;
> @@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)
>
>
> #if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
> -void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
> - struct drm_printer *p)
> +static void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
> + struct drm_printer *p)
> {
> int i, j;
> u32 pos = 0;
> --
> 2.23.0
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
