On Tue, 22 Oct 2019, David Lechner <da...@lechnology.com> wrote:
> On 10/22/19 5:09 AM, Jani Nikula wrote:
>> The DCS command has been named SET_PARTIAL_ROWS in the DCS spec since
>> v1.02, for more than a decade. Rename the enumeration to match the spec.
>>
>> Cc: David Lechner <da...@lechnology.com>
>> Cc: Vandita Kulkarni <vandita.kulka...@intel.com>
>> Signed-off-by: Jani Nikula <jani.nik...@intel.com>
>> ---
>
> I guess all of my documents are old and say set_partial_area, but I will
> take your word for it.
>
> It could be helpful to leave a comment in the code about the renaming
> so that if people with old docs search for SET_PARTIAL_AREA, they can
> still find it.
Something like this?
MIPI_DCS_SET_PARTIAL_ROWS = 0x30, /* aka
MIPI_DCS_SET_PARTIAL_AREA */
It's also a possibility to define both:
MIPI_DCS_SET_PARTIAL_AREA = 0x30, /* _ROWS since MIPI DCS
1.02 */
MIPI_DCS_SET_PARTIAL_ROWS = 0x30,
I don't mind either way.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
