On Tue, Nov 26, 2019 at 10:14:13AM +0100, Daniel Vetter wrote: > 0 means 1 as the default, but it's mighty confusing if the block size > for the first plane is spelled out explicitly, but not for the 2nd > plane. > > No cc: stable because this is just confusion, but 0 functional issue.
Acked-by: Liviu Dudau <[email protected]> Best regards, Liviu > > Fixes: 05f8bc82fc42 ("drm/fourcc: Add new P010, P016 video format") > Cc: Daniel Stone <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Cc: Randy Li <[email protected]> > Cc: Clint Taylor <[email protected]> > Cc: Ayan Kumar Halder <[email protected]> > Cc: Neil Armstrong <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Maxime Ripard <[email protected]> > Signed-off-by: Daniel Vetter <[email protected]> > --- > drivers/gpu/drm/drm_fourcc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index c630064ccf41..fe79ce857c8a 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -253,13 +253,13 @@ const struct drm_format_info *__drm_format_info(u32 > format) > .char_per_block = { 8, 0, 0 }, .block_w = { 2, 0, 0 }, > .block_h = { 2, 0, 0 }, > .hsub = 2, .vsub = 2, .is_yuv = true }, > { .format = DRM_FORMAT_P010, .depth = 0, > .num_planes = 2, > - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, > .block_h = { 1, 0, 0 }, > + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, > .block_h = { 1, 1, 0 }, > .hsub = 2, .vsub = 2, .is_yuv = true}, > { .format = DRM_FORMAT_P012, .depth = 0, > .num_planes = 2, > - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, > .block_h = { 1, 0, 0 }, > + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, > .block_h = { 1, 1, 0 }, > .hsub = 2, .vsub = 2, .is_yuv = true}, > { .format = DRM_FORMAT_P016, .depth = 0, > .num_planes = 2, > - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, > .block_h = { 1, 0, 0 }, > + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, > .block_h = { 1, 1, 0 }, > .hsub = 2, .vsub = 2, .is_yuv = true}, > { .format = DRM_FORMAT_P210, .depth = 0, > .num_planes = 2, .char_per_block = { 2, 4, 0 }, > -- > 2.24.0 > > _______________________________________________ > dri-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
