From: Thierry Reding <[email protected]>

The Tegra DRM never actually took that lock, so the driver was broken
until generic locking was added in commit:

        commit b962a12050a387e4bbf3a48745afe1d29d396b0d
        Author: Rob Clark <[email protected]>
        Date:   Mon Oct 22 14:31:22 2018 +0200

            drm/atomic: integrate modeset lock with private objects

It's now no longer necessary to take that lock, so drop the check.

v2: add rationale for why it is now safe to drop the check (Daniel)

Reviewed-by: Daniel Vetter <[email protected]>
Signed-off-by: Thierry Reding <[email protected]>
---
 drivers/gpu/drm/tegra/hub.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index 6aca0fd5a8e5..e56c0f7d3a13 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -615,11 +615,8 @@ static struct tegra_display_hub_state *
 tegra_display_hub_get_state(struct tegra_display_hub *hub,
                            struct drm_atomic_state *state)
 {
-       struct drm_device *drm = dev_get_drvdata(hub->client.parent);
        struct drm_private_state *priv;
 
-       WARN_ON(!drm_modeset_is_locked(&drm->mode_config.connection_mutex));
-
        priv = drm_atomic_get_private_obj_state(state, &hub->base);
        if (IS_ERR(priv))
                return ERR_CAST(priv);
-- 
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to