On Tue, Dec 17, 2019 at 11:53:09AM +0000, Ben Dooks (Codethink) wrote: > The malidp_mw_connector_helper_funcs is not referenced by name > outside of the file it is in, so make it static to avoid the > following warning: > > drivers/gpu/drm/arm/malidp_mw.c:59:41: warning: symbol > 'malidp_mw_connector_helper_funcs' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <[email protected]> > --- > Cc: Liviu Dudau <[email protected]>
Acked-by: Liviu Dudau <[email protected]> Best regards, Liviu > Cc: Brian Starkey <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: [email protected] > --- > drivers/gpu/drm/arm/malidp_mw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c > index 875a3a9eabfa..7d0e7b031e44 100644 > --- a/drivers/gpu/drm/arm/malidp_mw.c > +++ b/drivers/gpu/drm/arm/malidp_mw.c > @@ -56,7 +56,7 @@ malidp_mw_connector_mode_valid(struct drm_connector > *connector, > return MODE_OK; > } > > -const struct drm_connector_helper_funcs malidp_mw_connector_helper_funcs = { > +static const struct drm_connector_helper_funcs > malidp_mw_connector_helper_funcs = { > .get_modes = malidp_mw_connector_get_modes, > .mode_valid = malidp_mw_connector_mode_valid, > }; > -- > 2.24.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
