On 11/12/2019 00:57, Laurent Pinchart wrote:
In order to integrate with a chain of drm_bridge, the internal SDI
output has to expose its operations through the drm_bridge API.
Register a bridge at initialisation time to do so and remove the
omap_dss_device operations that are now unused.
Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
Changes since v2:
- Remove unused omapdss_device_connector_type() function
- Unregister bridge if port initialisation fails
---
drivers/gpu/drm/omapdrm/dss/base.c | 23 ----
drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
drivers/gpu/drm/omapdrm/dss/sdi.c | 168 +++++++++++++++--------
drivers/gpu/drm/omapdrm/omap_connector.c | 31 +----
4 files changed, 111 insertions(+), 112 deletions(-)
Do you have removal of the code in other files than sdi.c here in purpose? Can they be a separate
patch after this?
Single comment below, but other than that (with the code together if needed, or
in separate patches):
Reviewed-by: Tomi Valkeinen <tomi.valkei...@ti.com>
@@ -171,7 +144,7 @@ struct drm_connector *omap_connector_init(struct drm_device
*dev,
connector->doublescan_allowed = 0;
drm_connector_init(dev, connector, &omap_connector_funcs,
- omap_connector_get_type(output));
+ DRM_MODE_CONNECTOR_DSI);
This is because DSI is the only legacy output left, and thus all omap_connectors are DSI connectors?
Maybe a comment here to clarify.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
