Hi,

On 2/21/20 10:02 PM, Daniel Vetter wrote:
With this we can drop the final kfree from the release function.

Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Cc: Hans de Goede <hdego...@redhat.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdego...@redhat.com>

Regards,

Hans


---
  drivers/gpu/drm/tiny/gm12u320.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
index a48173441ae0..524ca0941cf9 100644
--- a/drivers/gpu/drm/tiny/gm12u320.c
+++ b/drivers/gpu/drm/tiny/gm12u320.c
@@ -19,6 +19,7 @@
  #include <drm/drm_gem_shmem_helper.h>
  #include <drm/drm_gem_framebuffer_helper.h>
  #include <drm/drm_ioctl.h>
+#include <drm/drm_managed.h>
  #include <drm/drm_modeset_helper_vtables.h>
  #include <drm/drm_probe_helper.h>
  #include <drm/drm_simple_kms_helper.h>
@@ -637,7 +638,6 @@ static void gm12u320_driver_release(struct drm_device *dev)
        gm12u320_usb_free(gm12u320);
        drm_mode_config_cleanup(dev);
        drm_dev_fini(dev);
-       kfree(gm12u320);
  }
DEFINE_DRM_GEM_FOPS(gm12u320_fops);
@@ -692,6 +692,7 @@ static int gm12u320_usb_probe(struct usb_interface 
*interface,
                return ret;
        }
        dev->dev_private = gm12u320;
+       drmm_add_final_kfree(dev, gm12u320);
drm_mode_config_init(dev);
        dev->mode_config.min_width = GM12U320_USER_WIDTH;


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to