Hi Paul,
> Am 30.03.2020 um 17:42 schrieb Rob Herring <r...@kernel.org>:
>
> On Sun, 29 Mar 2020 19:35:47 +0200, "H. Nikolaus Schaller" wrote:
>> and add compatible: jz4780-lcd, including an example how to
>> configure both lcd controllers.
>>
>> Also fix the clock names and examples.
>>
>> Based on work by Paul Cercueil <p...@crapouillou.net> and
>> Sam Ravnborg <s...@ravnborg.org>
>>
>> Signed-off-by: H. Nikolaus Schaller <h...@goldelico.com>
>> Cc: Rob Herring <r...@kernel.org>
>> Cc: devicet...@vger.kernel.org
>> ---
>> .../bindings/display/ingenic,lcd.txt | 45 ------
>> .../bindings/display/ingenic,lcd.yaml | 128 ++++++++++++++++++
>> 2 files changed, 128 insertions(+), 45 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt
>> create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic,lcd.example.dt.yaml:
> lcd-controller@13050000: clocks: [[4294967295, 9]] is too short
>
> See https://patchwork.ozlabs.org/patch/1263508
If I read the message correctly, I think there should be 2 clocks specified in
the jz4725b-lcd example and not just
clocks = <&cgu JZ4725B_CLK_LCD>;
Unfortunately the jz4725b.dtsi does not seem to be upstream or in linux-next so
I don't know if it works without lcd_pclk or not.
If there is really just one clock, we need to modify the clocks and clock-names
schema and add minItems: 1 and maxItems: 2 to allow for this flexibility.
Otherwise we have to fix the example. Do you have some git with an up-to-date
jz4725b.dtsi to look at?
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
> --upgrade
+++ :)
>
> Please check and re-submit.
Sure, since it is a RFC.
BR and thanks,
Nikolaus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
