Hi Gareth.
Looking forward to see the other patches - they seem to be stuck
awaiting approval.
A few comments in the following.
Sam
On Mon, Apr 27, 2020 at 09:21:49AM +0100, Gareth Williams wrote:
> This commit adds support for the Newhaven ATXL#-CTP panel used by the
> Renesas RZ/N1 Demo Board.
>
> Signed-off-by: Gareth Williams <gareth.williams...@renesas.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index 5a93c4e..0b57b0e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2021,6 +2021,30 @@ static const struct panel_desc
> newhaven_nhd_43_480272ef_atxl = {
> DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,
> };
>
> +static const struct display_timing newhaven_nhd_50_800480tf_atxl_timing = {
> + .pixelclock = { 33300000, 33400000, 33500000 },
> + .hactive = { 800, 800, 800 },
> + .hfront_porch = { 40, 40, 40 },
> + .hback_porch = { 88, 88, 88 },
> + .hsync_len = { 1, 1, 1 },
> + .vactive = { 480, 480, 480 },
> + .vfront_porch = { 13, 13, 13 },
> + .vback_porch = { 32, 32, 32 },
> + .vsync_len = { 3, 3, 3 },
> + .flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_HIGH,
> +};
> +
> +static const struct panel_desc newhaven_nhd_50_800480tf_atxl = {
> + .timings = &newhaven_nhd_50_800480tf_atxl_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 400,
> + .height = 300,
> + },
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
Please add DRM_BUS_FLAG_PIXDATA too - as I assume this is an LVDS panel.
> +};
For new panels .connector_type is mandatory.
> +
> static const struct display_timing nlt_nl192108ac18_02d_timing = {
> .pixelclock = { 130000000, 148350000, 163000000 },
> .hactive = { 1920, 1920, 1920 },
> @@ -2964,6 +2988,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "newhaven,nhd-4.3-480272ef-atxl",
> .data = &newhaven_nhd_43_480272ef_atxl,
> }, {
> + .compatible = "newhaven,nhd-5.0-800480tf-atxl",
> + .data = &newhaven_nhd_50_800480tf_atxl,
> + }, {
I did not see the other patches - so this is maybe covered.
But newhaven,nhd-5.0-800480tf-atxl must be documented in
panel-simple.yaml before we can apply this.
Sam
> .compatible = "nlt,nl192108ac18-02d",
> .data = &nlt_nl192108ac18_02d,
> }, {
> --
> 2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
