Hi Richard.

On Sat, May 09, 2020 at 01:18:34PM +0200, s...@48.io wrote:
> From: Sean Cross <x...@kosagi.com>
> 
> The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> integrated backlight, and connects via eDP.
> 
> It is used in the Kosagi Novena.

Thanks for the patch.


> 
> Signed-off-by: Sean Cross <x...@kosagi.com>
> Signed-off-by: Richard Marko <s...@48.io>
> Cc: Shawn Guo <shawn...@kernel.org>
> Cc: Fabio Estevam <fabio.este...@nxp.com>
> Cc: Thierry Reding <thierry.red...@gmail.com>
> To: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..c8a93771d398 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = {
>       },
>  };
>  
> +static const struct drm_display_mode innolux_n133hse_ea1_mode = {
> +     .clock = 138500,
> +     .hdisplay = 1920,
> +     .hsync_start = 1920 + 46,
> +     .hsync_end = 1920 + 46 + 30,
> +     .htotal = 1920 + 46 + 30 + 84,
> +     .vdisplay = 1080,
> +     .vsync_start = 1080 + 2,
> +     .vsync_end = 1080 + 2 + 4,
> +     .vtotal = 1080 + 2 + 4 + 26,
> +     .vrefresh = 60,
> +};
> +
> +static const struct panel_desc innolux_n133hse_ea1 = {
> +     .modes = &innolux_n133hse_ea1_mode,
> +     .num_modes = 1,
> +     .bpc = 8,
> +     .size = {
> +             .width = 293,
> +             .height = 165,
> +     },
> +     .connector_type = DRM_MODE_CONNECTOR_eDP,
Please include .bus_format and .bus_flags info too.

We are relying more and more on this type of info so we need it to be
present.

        Sam



> +};
> +
>  static const struct drm_display_mode innolux_n156bge_l21_mode = {
>       .clock = 69300,
>       .hdisplay = 1366,
> @@ -3577,6 +3601,9 @@ static const struct of_device_id platform_of_match[] = {
>       }, {
>               .compatible = "innolux,n116bge",
>               .data = &innolux_n116bge,
> +     }, {
> +             .compatible = "innolux,n133hse-ea1",
> +             .data = &innolux_n133hse_ea1,
>       }, {
>               .compatible = "innolux,n156bge-l21",
>               .data = &innolux_n156bge_l21,
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to