Hi Emil Am 12.05.20 um 12:27 schrieb Emil Velikov: > Hi Thomas, > > On Tue, 12 May 2020 at 09:43, Thomas Zimmermann <tzimmerm...@suse.de> wrote: > >> @@ -1143,20 +1178,15 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, >> WREG_CRT(13, 0); >> WREG_CRT(14, 0); >> WREG_CRT(15, 0); >> - WREG_CRT(19, pitch & 0xFF); >> - > This write has disappeared without an equivalent or a comment. > Is that intentional?
It's still there. It's now located in mgag200_set_offset() and 19 is written as 0x13. :) I try to follow the naming style of the MGA programming manual, which prefers hexadecimal numbers. Best regards Thomas > > > -Emil > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
