发件人：Chun-Kuang Hu <chunkuang...@kernel.org>
发送日期：2020-06-15 22:00:52
收件人：Joe Perches <j...@perches.com>
抄送人：Bernard Zhao <bern...@vivo.com>,Chun-Kuang Hu
<chunkuang...@kernel.org>,Philipp Zabel <p.za...@pengutronix.de>,David Airlie
<airl...@linux.ie>,Daniel Vetter <dan...@ffwll.ch>,Matthias Brugger
<matthias....@gmail.com>,DRI Development
<dri-devel@lists.freedesktop.org>,Linux ARM
<linux-arm-ker...@lists.infradead.org>,"moderated list:ARM/Mediatek SoC
support" <linux-media...@lists.infradead.org>,linux-kernel
<linux-ker...@vger.kernel.org>,opensource.ker...@vivo.com
主题：Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool>Joe Perches
<j...@perches.com> 於 2020年6月15日 週一 上午4:41寫道：
>>
>> On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote:
>> > In function mtk_dsi_clk_hs_state, remove unnecessary conversion
>> > to bool return, this change is to make the code a bit readable.
>> []
>> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
>> > b/drivers/gpu/drm/mediatek/mtk_dsi.c
>> []
>> > @@ -319,7 +319,7 @@ static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
>> > u32 tmp_reg1;
>> >
>> > tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON);
>> > - return ((tmp_reg1 & LC_HS_TX_EN) == 1) ? true : false;
>> > + return ((tmp_reg1 & LC_HS_TX_EN) == 1);
>>
>> Given:
>>
>> drivers/gpu/drm/mediatek/mtk_dsi.c:#define LC_HS_TX_EN
>> BIT(0)
>>
>> This is likely clearer as
>>
>> return tmp_reg1 & LC_HS_TX_EN;
>>
>> or even
>>
>> static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
>> {
>> return readl(dsi->regs + DSI_PHY_LCCON) & LC_HS_TX_EN;
>> }
>
>I like the second one.
Hi:
This modification is clear and easy to understand.
I will update the patch and resubmit.
Thanks!
BR//Bernard
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
