Am 29.06.20 um 23:10 schrieb Wolfram Sang:
Hi Alexander,

thanks for trying to fix this, yet I have some doubts.

On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:

I think we need some text here. Clicking on a link to understand what a
patch is about is not comfortable. You can add the link with a Link: tag
for additional information.
Fine. I can easily make a v2 patch, but first...

Removing stale email addresses may have some value, but removing...

  Compaq's Bootldr + John Dorsey's patch for Assabet support

... information like this is not good. 'Wayback machine' still has
copies in case someone wants to look at where the infos came from.
If we shall not remove *this link*, maybe we shall not remove *all links*?

@Jon You've kinda initiated the patch, what's your opinion? Bad squatters or good Wayback machine?

- * Copyright 2004-2005  Phil Blundell <>
+ * Copyright 2004-2005  Phil Blundell

This is an OK case in my book...

-MODULE_AUTHOR("Phil Blundell <>");
+MODULE_AUTHOR("Phil Blundell");

... same here ...

@@ -435,7 +435,6 @@
                             case a PCI bridge (DEC chip 21152). The value of
                             'pb' is now only initialized if a de4x5 chip is
-                           <>

This is kind of a signature and should be kept IMO.
What for? An email address is for someone who'd like to send an email to it. At the moment doesn't even have an MX record.

   * 2001/07/23: <>
- *     - Hand merge version from CVS tree.  See patch
+ *     - Hand merge version from CVS tree.  See patch

That information may be useful.
Again: What for? For visiting it and thinking like damn, it's gone?

  /* SPDX-License-Identifier: GPL-2.0-only */
  /* -*- linux-c -*-
- *
- * (C) 2003

Removing copyright is a bad idea.
IMAO the CREDITS file is for (c) headers.
If you didn't submit a patch for that - your problem.

If you disagree, I can look up git blame.

Probably some comment blocks are cruft meanwhile and can be removed as a
whole. That can be discussed. But removing only the part
makes most parts worse IMHO.

Thanks and happy hacking,


dri-devel mailing list

Reply via email to