On Thu, Aug 20, 2020 at 02:12:55PM +0200, Paul Cercueil wrote:
> The drm_panel_of_backlight() function must be called after
> drm_panel_init(), according to the function's documentation; otherwise
> the backlight won't be properly initialized.
>
> v2: New patch
>
> Signed-off-by: Paul Cercueil <p...@crapouillou.net>
Reviewed-by: Sam Ravnborg <s...@ravnborg.org>
> ---
> drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> index 39f7be679da5..daa583030246 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> @@ -285,6 +285,9 @@ static int nt39016_probe(struct spi_device *spi)
> return PTR_ERR(panel->map);
> }
>
> + drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
> + DRM_MODE_CONNECTOR_DPI);
> +
> err = drm_panel_of_backlight(&panel->drm_panel);
> if (err) {
> if (err != -EPROBE_DEFER)
> @@ -292,9 +295,6 @@ static int nt39016_probe(struct spi_device *spi)
> return err;
> }
>
> - drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
> - DRM_MODE_CONNECTOR_DPI);
> -
> drm_panel_add(&panel->drm_panel);
>
> return 0;
> --
> 2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
