Hi, On Fri, Oct 02, 2020 at 09:56:20AM +0200, Daniel Vetter wrote: > Crank up the warning a notch and point at the right set of locking > functions for atomic drivers. > > Signed-off-by: Daniel Vetter <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Thomas Zimmermann <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Daniel Vetter <[email protected]> > --- > drivers/gpu/drm/drm_atomic.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index aac9122f1da2..b2d20eb6c807 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -1642,11 +1642,11 @@ static void __drm_state_dump(struct drm_device *dev, > struct drm_printer *p, > * to dmesg in case of error irq's. (Hint, you probably want to > * ratelimit this!) > * > - * The caller must drm_modeset_lock_all(), or if this is called > - * from error irq handler, it should not be enabled by default. > - * (Ie. if you are debugging errors you might not care that this > - * is racey. But calling this without all modeset locks held is > - * not inherently safe.) > + * The caller must wrap this drm_modeset_lock_all_ctx() and > + * drm_modeset_drop_locks(). If this is called from error irq handler, it > should > + * not be enabled by default - if you are debugging errors you might > + * not care that this is racey, but calling this without all modeset locks > held > + * is inherently unsafe. > */ > void drm_state_dump(struct drm_device *dev, struct drm_printer *p) > {
For the comment itself: Acked-by: Maxime Ripard <[email protected]> But maybe we should add some lockdep assertion to make sure we can catch someone actually doing this?
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
