Re: [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning

[Thomas Zimmermann]

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

The goldfish_fb_acpi_match table is only used with ACPI enabled.
Ifdef it out unless it is needed.
This is a similar fix to what other acpi drivers do.

Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
Cc: Sam Ravnborg <s...@ravnborg.org>

Acked-by: Thomas Zimmermann <tzimmerm...@suse.de>

---
  drivers/video/fbdev/goldfishfb.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 9c83ec3f8e1f..2b885cd046fe 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -305,11 +305,13 @@ static const struct of_device_id goldfish_fb_of_match[] = 
{
  };
  MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);

  static const struct acpi_device_id goldfish_fb_acpi_match[] = {
        { "GFSH0004", 0 },
        { },
  };
  MODULE_DEVICE_TABLE(acpi, goldfish_fb_acpi_match);
+#endif

        .probe          = goldfish_fb_probe,

+#ifdef CONFIG_ACPI static struct platform_driver goldfish_fb_driver = {

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel