On Tue, Dec 08, 2020 at 06:13:20PM +0000, Xiong, Jianxin wrote:

> > > +static inline struct ib_umem *ib_umem_dmabuf_get(struct ib_device 
> > > *device,
> > > +                                          unsigned long offset,
> > > +                                          size_t size, int fd,
> > > +                                          int access,
> > > +                                          struct dma_buf_attach_ops 
> > > *ops) {
> > > + return ERR_PTR(-EINVAL);
> > 
> > Probably, It should be EOPNOTSUPP and not EINVAL.
> 
> EINVAL is used here to be consistent with existing definitions in the same 
> file.

They may be wrong, EOPNOTSUPP is right for this situation

Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to