So we don't have to change the prototype if we extend the function.

Signed-off-by: Boris Brezillon <boris.brezil...@collabora.com>
---
 drivers/gpu/drm/panfrost/panfrost_job.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c 
b/drivers/gpu/drm/panfrost/panfrost_job.c
index 6003cfeb1322..564054a96ca9 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -196,24 +196,20 @@ static void panfrost_job_hw_submit(struct panfrost_job 
*job, int js)
        job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
 }
 
-static void panfrost_acquire_object_fences(struct drm_gem_object **bos,
-                                          int bo_count,
-                                          struct dma_fence **implicit_fences)
+static void panfrost_acquire_object_fences(struct panfrost_job *job)
 {
        int i;
 
-       for (i = 0; i < bo_count; i++)
-               implicit_fences[i] = dma_resv_get_excl_rcu(bos[i]->resv);
+       for (i = 0; i < job->bo_count; i++)
+               job->implicit_fences[i] = 
dma_resv_get_excl_rcu(job->bos[i]->resv);
 }
 
-static void panfrost_attach_object_fences(struct drm_gem_object **bos,
-                                         int bo_count,
-                                         struct dma_fence *fence)
+static void panfrost_attach_object_fences(struct panfrost_job *job)
 {
        int i;
 
-       for (i = 0; i < bo_count; i++)
-               dma_resv_add_excl_fence(bos[i]->resv, fence);
+       for (i = 0; i < job->bo_count; i++)
+               dma_resv_add_excl_fence(job->bos[i]->resv, 
job->render_done_fence);
 }
 
 int panfrost_job_push(struct panfrost_job *job)
@@ -243,15 +239,13 @@ int panfrost_job_push(struct panfrost_job *job)
 
        kref_get(&job->refcount); /* put by scheduler job completion */
 
-       panfrost_acquire_object_fences(job->bos, job->bo_count,
-                                      job->implicit_fences);
+       panfrost_acquire_object_fences(job);
 
        drm_sched_entity_push_job(&job->base, entity);
 
        mutex_unlock(&pfdev->sched_lock);
 
-       panfrost_attach_object_fences(job->bos, job->bo_count,
-                                     job->render_done_fence);
+       panfrost_attach_object_fences(job);
 
 unlock:
        drm_gem_unlock_reservations(job->bos, job->bo_count, &acquire_ctx);
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to