Hello Christophe, [dropping krzysztof...@poczta.fm from recipents, the address doesn't seem to exist]
On Fri, May 07, 2021 at 09:11:19AM +0200, Christophe JAILLET wrote:
> Le 07/05/2021 à 07:05, Uwe Kleine-König a écrit :
> > On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:
> > > 'ret' is known to be 0 here.
> > > No error code is available, so just remove it from the error message.
> > >
> > > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of
> > > direct pointer deref")
> > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
> > > ---
> > > drivers/video/fbdev/imxfb.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> > > index 7f8debd2da06..ad598257ab38 100644
> > > --- a/drivers/video/fbdev/imxfb.c
> > > +++ b/drivers/video/fbdev/imxfb.c
> > > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev)
> > > info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size,
> > > &fbi->map_dma, GFP_KERNEL);
> > > if (!info->screen_buffer) {
> > > - dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret);
> > > + dev_err(&pdev->dev, "Failed to allocate video RAM\n");
> > > ret = -ENOMEM;
> > > goto failed_map;
> > > }
> >
> > Reviewed-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
> >
> > Are you using this driver, or did you find that problem using some
> > static checker?
>
> No, I'm not using this driver AFAIK.
OK, thanks. (We're working on a DRM driver for this hardware. So you
could have been an interested tester.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
