On Mon 07 Jun 12:05 CDT 2021, Douglas Anderson wrote:

> Putting the panel under the bridge chip (under the aux-bus node)
> allows the panel driver to get access to the DP AUX bus, enabling all
> sorts of fabulous new features.
> 
> While we're at this, get rid of a level of hierarchy for the panel
> node. It doesn't need "ports / port" and can just have a "port" child.
> 
> For Linux, this patch has a hard requirement on the patches adding DP
> AUX bus support to the ti-sn65dsi86 bridge chip driver. See the patch
> ("drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus").
> 
> Signed-off-by: Douglas Anderson <[email protected]>
> Acked-by: Linus Walleij <[email protected]>

In case you want to merge this together with the driver changes
(even though there's no direct need for them to go together):

Acked-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> 
> (no changes since v7)
> 
> Changes in v7:
> - Panel now under bridge chip instead of getting a link to ddc-i2c
> 
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 30 ++++++++++----------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi 
> b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 24d293ef56d7..c76afd857b54 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -260,21 +260,6 @@ max98357a: audio-codec-0 {
>               #sound-dai-cells = <0>;
>       };
>  
> -     panel: panel {
> -             /* Compatible will be filled in per-board */
> -             power-supply = <&pp3300_dx_edp>;
> -             backlight = <&backlight>;
> -             hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>;
> -
> -             ports {
> -                     port {
> -                             panel_in_edp: endpoint {
> -                                     remote-endpoint = <&sn65dsi86_out>;
> -                             };
> -                     };
> -             };
> -     };
> -
>       pwmleds {
>               compatible = "pwm-leds";
>               keyboard_backlight: keyboard-backlight {
> @@ -674,6 +659,21 @@ sn65dsi86_out: endpoint {
>                               };
>                       };
>               };
> +
> +             aux-bus {
> +                     panel: panel {
> +                             /* Compatible will be filled in per-board */
> +                             power-supply = <&pp3300_dx_edp>;
> +                             backlight = <&backlight>;
> +                             hpd-gpios = <&sn65dsi86_bridge 2 
> GPIO_ACTIVE_HIGH>;
> +
> +                             port {
> +                                     panel_in_edp: endpoint {
> +                                             remote-endpoint = 
> <&sn65dsi86_out>;
> +                                     };
> +                             };
> +                     };
> +             };
>       };
>  };
>  
> -- 
> 2.32.0.rc1.229.g3e70b5a671-goog
> 

Reply via email to