Re: [PATCH v2 2/4] drm/msm/dpu: drop pe argument from _dpu_hw_sspp_setup_scaler3

[Abhinav Kumar]

+ Dan C for awareness as this is a follow up of our discussion on
https://lore.kernel.org/linux-arm-msm/c1537b326b654f05be247ca61d21e...@codeaurora.org/T/
On 12/1/2021 2:51 PM, Dmitry Baryshkov wrote:
The _dpu_hw_sspp_setup_scaler3 (hw_sspp->setup_scaler) does not use pe
argument. Let's remove it while we are cleaning scaled configuration.

Thanks for pushing this.

This was originally reported by Dan Carpenter.

Hence, please add the Reported-by tag for Dan on this (Dan Carpenter 
<dan.carpen...@oracle.com> )


Apart from that,
Reviewed-by: Abhinav Kumar <quic_abhin...@quicinc.com>

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 --
  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 --
  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c   | 2 +-
  3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
index d77eb7da5daf..7235605bfc9e 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
@@ -413,13 +413,11 @@ static void dpu_hw_sspp_setup_pe_config(struct 
dpu_hw_pipe *ctx,
  
  static void _dpu_hw_sspp_setup_scaler3(struct dpu_hw_pipe *ctx,
                struct dpu_hw_pipe_cfg *sspp,
-               struct dpu_hw_pixel_ext *pe,
                void *scaler_cfg)
  {
        u32 idx;
        struct dpu_hw_scaler3_cfg *scaler3_cfg = scaler_cfg;
  
-	(void)pe;
        if (_sspp_subblk_offset(ctx, DPU_SSPP_SCALER_QSEED3, &idx) || !sspp
                || !scaler3_cfg)
                return;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
index e8939d7387cb..ad2002d75739 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
@@ -334,12 +334,10 @@ struct dpu_hw_sspp_ops {
         * setup_scaler - setup scaler
         * @ctx: Pointer to pipe context
         * @pipe_cfg: Pointer to pipe configuration
-        * @pe_cfg: Pointer to pixel extension configuration
         * @scaler_cfg: Pointer to scaler configuration
         */
        void (*setup_scaler)(struct dpu_hw_pipe *ctx,
                struct dpu_hw_pipe_cfg *pipe_cfg,
-               struct dpu_hw_pixel_ext *pe_cfg,
                void *scaler_cfg);
  
  	/**
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 4c373abbe89c..c7b065b14c5c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -688,7 +688,7 @@ static void _dpu_plane_setup_scaler(struct dpu_plane *pdpu,
        if (pdpu->pipe_hw->ops.setup_scaler &&
                        pstate->multirect_index != DPU_SSPP_RECT_1)
                pdpu->pipe_hw->ops.setup_scaler(pdpu->pipe_hw,
-                               pipe_cfg, &pixel_ext,
+                               pipe_cfg,
                                &scaler3_cfg);
  }