On Tue, 25 Jan 2022, Maxime Ripard <[email protected]> wrote: > Even though we have the other drm_display_info fields reset, the DC > modes are missing. > > This shouldn't be an issue since it's explicitely reset every time a new > EDID is parsed.
Side note, and hijacking the thread a bit: I think it's a historical mistake we've started accumulating stuff in struct drm_display_info that is *not* derived from the EDID or DisplayID. I think drm_reset_display_info() should just be one memset() and that's it. Adding stuff that should not be reset here feels wrong. Maybe we should just move all the non-EDID derived members directly to struct drm_connector? Or some other sub-struct. In the mean time, this patch seems like the right thing to do, Reviewed-by: Jani Nikula <[email protected]> BR, Jani. > > Suggested-by: Ville Syrjälä <[email protected]> > Signed-off-by: Maxime Ripard <[email protected]> > --- > drivers/gpu/drm/drm_edid.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 5251925e3b92..a76224653e6f 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -5340,6 +5340,9 @@ drm_reset_display_info(struct drm_connector *connector) > info->rgb_quant_range_selectable = false; > memset(&info->hdmi, 0, sizeof(info->hdmi)); > > + info->edid_hdmi_rgb444_dc_modes = 0; > + info->edid_hdmi_ycbcr444_dc_modes = 0; > + > info->non_desktop = 0; > memset(&info->monitor_range, 0, sizeof(info->monitor_range)); -- Jani Nikula, Intel Open Source Graphics Center
