On 07/02/2022 18:35, Maxime Ripard wrote:
The omap KMS driver will call drm_plane_create_zpos_property() with an init value of the plane index and the plane type.Since the initial value wasn't carried over in the state, the driver had to set it again in omap_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: Tomi Valkeinen <to...@kernel.org> Signed-off-by: Maxime Ripard <max...@cerno.tech> --- drivers/gpu/drm/omapdrm/omap_plane.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c index e67baf9a942c..d96bc929072a 100644 --- a/drivers/gpu/drm/omapdrm/omap_plane.c +++ b/drivers/gpu/drm/omapdrm/omap_plane.c @@ -414,13 +414,6 @@ static void omap_plane_reset(struct drm_plane *plane) return;__drm_atomic_helper_plane_reset(plane, &omap_state->base);- - /* - * Set the zpos default depending on whether we are a primary or overlay - * plane. - */ - plane->state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY - ? 0 : omap_plane->id; plane->state->color_encoding = DRM_COLOR_YCBCR_BT601; plane->state->color_range = DRM_COLOR_YCBCR_FULL_RANGE; }
Reviewed-by: Tomi Valkeinen <tomi.valkei...@ideasonboard.com> Tomi
