Am Mittwoch, 9. Februar 2022, 10:53:29 CET schrieb Sascha Hauer: > The driver returns an error when devm_phy_optional_get() fails leaving > the previously enabled clock turned on. Change order and enable the > clock only after the phy has been acquired. > > Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de>
just a note for me, already applied to drm-misc-fixes: https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=c0cfbb122275da1b726481de5a8cffeb24e6322b > --- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index 830bdd5e9b7c..8677c8271678 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -529,13 +529,6 @@ static int dw_hdmi_rockchip_bind(struct device *dev, > struct device *master, > return ret; > } > > - ret = clk_prepare_enable(hdmi->vpll_clk); > - if (ret) { > - DRM_DEV_ERROR(hdmi->dev, "Failed to enable HDMI vpll: %d\n", > - ret); > - return ret; > - } > - > hdmi->phy = devm_phy_optional_get(dev, "hdmi"); > if (IS_ERR(hdmi->phy)) { > ret = PTR_ERR(hdmi->phy); > @@ -544,6 +537,13 @@ static int dw_hdmi_rockchip_bind(struct device *dev, > struct device *master, > return ret; > } > > + ret = clk_prepare_enable(hdmi->vpll_clk); > + if (ret) { > + DRM_DEV_ERROR(hdmi->dev, "Failed to enable HDMI vpll: %d\n", > + ret); > + return ret; > + } > + > drm_encoder_helper_add(encoder, &dw_hdmi_rockchip_encoder_helper_funcs); > drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); > >
