Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

[Paul Menzel]

Dear David,

Thank you for your patch.

Am 31.03.22 um 19:26 schrieb David Zhang:
[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
support.

You could be specific by using the exact number two. Maybe:

As per eDP 1.5 specification, add the two DPCD bit fields below for 
PSR-SU support:

1.  DP_PSR2_WITH_Y_COORD_ET_SUPPORTED
2.  DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED


Kind regards,

Paul

Signed-off-by: David Zhang <dingchen.zh...@amd.com>
---
  include/drm/drm_dp_helper.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 30359e434c3f..ac7b7571ae66 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -361,6 +361,7 @@ struct drm_panel;
  # define DP_PSR_IS_SUPPORTED                1
  # define DP_PSR2_IS_SUPPORTED             2       /* eDP 1.4 */
  # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED  3     /* eDP 1.4a */
+# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED  4      /* eDP 1.5, adopted eDP 
1.4b SCR */
  
  #define DP_PSR_CAPS                         0x071   /* XXX 1.2? */
  # define DP_PSR_NO_TRAIN_ON_EXIT            1
@@ -375,6 +376,7 @@ struct drm_panel;
  # define DP_PSR_SETUP_TIME_SHIFT            1
  # define DP_PSR2_SU_Y_COORDINATE_REQUIRED   (1 << 4)  /* eDP 1.4a */
  # define DP_PSR2_SU_GRANULARITY_REQUIRED    (1 << 5)  /* eDP 1.4b */
+# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 
1.4b SCR */
  
  #define DP_PSR2_SU_X_GRANULARITY	    0x072 /* eDP 1.4b */
  #define DP_PSR2_SU_Y_GRANULARITY          0x074 /* eDP 1.4b */